Add support for alpha, linewidths and edgecolors to agent_portrayal #2468
+122
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Performance benchmarks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2341 and adds support for alpha, linewidths and edgecolors as possible values in agent_portrayal. I also did it in such a way that you can either do it at the level of the individual agent or as an overall space_drawing_kwargs argument but get a value error if you do both.
In addition, I updated the tests and solved a few subtle bugs in draw_space related to the match statement.
It would be great to get this in for MESA 3, because the bug is rather subtle due to the complicated class structure in old-style grids.